Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust breakage with nr2 #3266

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix rust breakage with nr2 #3266

merged 1 commit into from
Jan 21, 2025

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Nov 25, 2024

Nr2 did not emit the correct error message for break identifier "rust".

@P-E-P P-E-P changed the title Fix rust breakage with nr2 Draft: Fix rust breakage with nr2 Nov 25, 2024
@P-E-P P-E-P marked this pull request as draft November 25, 2024 17:40
@P-E-P P-E-P changed the title Draft: Fix rust breakage with nr2 Fix rust breakage with nr2 Nov 25, 2024
@P-E-P P-E-P force-pushed the fix-rust-breakage branch 2 times, most recently from d7b22d5 to 4be86b5 Compare November 26, 2024 10:22
@P-E-P P-E-P force-pushed the fix-rust-breakage branch 2 times, most recently from 1cf4136 to f571b37 Compare January 11, 2025 16:55
@P-E-P P-E-P marked this pull request as ready for review January 11, 2025 16:57
@P-E-P P-E-P requested a review from CohenArthur January 13, 2025 10:28
@P-E-P
Fix rust breakage with nr2
3f76f73 
Nr2 did not emit the correct error message for break identifier "rust".

gcc/rust/ChangeLog:

	* resolve/rust-late-name-resolver-2.0.cc (Late::visit): Add "rust"
	identifier detection akin to nr1.
	(funny_ice_finalizer): Copy ICE finalizer from nr1.
	* resolve/rust-late-name-resolver-2.0.h: Add funny_error member
	context state.
	* Make-lang.in: Add new translation unit for new ice finalizer.
	* resolve/rust-ast-resolve-expr.cc: Move ice
	finalizer to it's own file.
	* resolve/rust-ice-finalizer.cc: New file.
	* resolve/rust-ice-finalizer.h: New file.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove break-rust3.rs from exclude list.

Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
@P-E-P P-E-P force-pushed the fix-rust-breakage branch from f571b37 to 3f76f73 Compare January 14, 2025 12:16
@P-E-P P-E-P added this pull request to the merge queue Jan 21, 2025
Merged via the queue into Rust-GCC:master with commit 289bf52 Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur Awaiting requested review from CohenArthur

Assignees

@P-E-P P-E-P

Labels
name resolution Rust Integrations
Projects
name resolution 2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-E-P @philberty